Skip to content

Shewchuk's predicates support#1163

Merged
alecjacobson merged 8 commits intolibigl:devfrom
PyMesh:dev
Apr 20, 2019
Merged

Shewchuk's predicates support#1163
alecjacobson merged 8 commits intolibigl:devfrom
PyMesh:dev

Conversation

@qnzhou
Copy link
Copy Markdown
Collaborator

@qnzhou qnzhou commented Apr 19, 2019

Add support for Shewchuk's exact predicates.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@qnzhou qnzhou requested review from hankstag and jdumas April 19, 2019 03:28
@jdumas jdumas added the feature label Apr 19, 2019
jdumas
jdumas requested changes Apr 19, 2019
View reviewed changes
Comment thread include/igl/predicates/predicates.cpp Outdated
Comment thread include/igl/predicates/predicates.cpp Outdated
Comment thread include/igl/predicates/predicates.cpp Outdated
Comment thread include/igl/predicates/predicates.cpp Outdated
hankstag
hankstag reviewed Apr 19, 2019
View reviewed changes
Comment thread include/igl/predicates/predicates.h Outdated
hankstag
hankstag reviewed Apr 19, 2019
View reviewed changes
Comment thread cmake/libigl.cmake
@alecjacobson alecjacobson merged commit bc657bc into libigl:dev Apr 20, 2019
@robertliebo robertliebo mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdumas jdumas jdumas approved these changes

+1 more reviewer

@hankstag hankstag hankstag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qnzhou @jdumas @hankstag @alecjacobson