Merged
Conversation
12c23ec to
341e7b2
Compare
Contributor
|
Has this been tested on Mac, Ubuntu and Windows ? (not just CI but actually testing that the tutorial windows appear correctly etc.) |
Collaborator
Author
|
I have tested tutorials 102, 107 and 108 on my Archlinux and they work as expected. I can test on Windows too since we don't have many Windows users, but I don't have a Mac. |
Collaborator
Author
|
Also tested on Windows, and it works fine. I also fixed a cmake issue with top-level project detection (somehow was not working on Windows). |
Contributor
|
@jdumas @alecjacobson just wanted to let you know: everything looks fine and behaves as I'd expected it on my MacBook(macOS Mojave 10.14.4)! To do so I took the following steps: |
danielepanozzo
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable version of GLFW 3.3 came out today, so I thought we might update our dependency accordingly.
I've also updated Embree and use git urls instead of direct download due to #1019.
Check all that apply (change to
[x])