Skip to content

Update GLFW to 3.3#1153

Merged
jdumas merged 3 commits intodevfrom
update-libs
May 7, 2019
Merged

Update GLFW to 3.3#1153
jdumas merged 3 commits intodevfrom
update-libs

Conversation

@jdumas
Copy link
Copy Markdown
Collaborator

@jdumas jdumas commented Apr 16, 2019

Stable version of GLFW 3.3 came out today, so I thought we might update our dependency accordingly.
I've also updated Embree and use git urls instead of direct download due to #1019.

Check all that apply (change to [x])

@jdumas jdumas force-pushed the update-libs branch 4 times, most recently from 12c23ec to 341e7b2 Compare April 16, 2019 13:08
@alecjacobson
Copy link
Copy Markdown
Contributor

Has this been tested on Mac, Ubuntu and Windows ? (not just CI but actually testing that the tutorial windows appear correctly etc.)

@jdumas
Copy link
Copy Markdown
Collaborator Author

jdumas commented May 2, 2019

I have tested tutorials 102, 107 and 108 on my Archlinux and they work as expected. I can test on Windows too since we don't have many Windows users, but I don't have a Mac.

@jdumas
Copy link
Copy Markdown
Collaborator Author

jdumas commented May 3, 2019

Also tested on Windows, and it works fine. I also fixed a cmake issue with top-level project detection (somehow was not working on Windows).

@BruegelN
Copy link
Copy Markdown
Contributor

BruegelN commented May 6, 2019

@jdumas @alecjacobson just wanted to let you know: everything looks fine and behaves as I'd expected it on my MacBook(macOS Mojave 10.14.4)!
I've tested 102, 107 and 108 as well as 106 & 708.

To do so I took the following steps:

git clone https://github.com/libigl/libigl.git
cd libigl
git checkout dev
git pull origin update-libs
mkdir build
cd build
cmake ../
make -j4

@jdumas jdumas merged commit 10e04cb into dev May 7, 2019
@jdumas jdumas deleted the update-libs branch May 7, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants