Fixed two memory leaks#1120
Merged
jdumas merged 2 commits intolibigl:devfrom Apr 20, 2019
robertguetzkow:dev
Merged
Conversation
One pointer to allocated memory wasn't freed and realloc didn't have proper error handling. Additionally UB has been identified, because a pointer to a local variable is returned.
Contributor
Author
|
From what I've seen the implementation needs a major overhaul or a complete replacement. There are also string processing operations that don't look safe. |
Collaborator
|
As discussed in the thread ideally we should replace it by another library entirely, e.g. tinyply. I believe dropping the file in |
Contributor
Author
|
@jdumas that would be the best solution. I just thought fixing the bugs until we have a replacement would help a bit. |
Collaborator
|
I mean if you want to give it a shot at integrating tinyply or rply, feel free to do so! |
…leting the object
jdumas
approved these changes
Apr 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #919 the ply.h implementation has several code quality issues. The suggested changes fix two memory leaks. One is caused by a missing free, another from improper handling when realloc fails. Additionally UB has been identified, because a pointer to a local variable is returned.
Check all that apply (change to
[x])