Extending igl::cat to work with std::vectors AND Allowing N-gons in writeOBJ#1108
Merged
jdumas merged 18 commits intolibigl:devfrom Apr 27, 2019
Merged
Extending igl::cat to work with std::vectors AND Allowing N-gons in writeOBJ#1108jdumas merged 18 commits intolibigl:devfrom
jdumas merged 18 commits intolibigl:devfrom
Conversation
jdumas
requested changes
Mar 7, 2019
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Looks fine, but I don't understand the change from MatrixBase to PlainObjectBase (the FAQ says to use MatrixBase for inputs).
jdumas
reviewed
Mar 7, 2019
jdumas
reviewed
Mar 7, 2019
jdumas
reviewed
Mar 7, 2019
jdumas
requested changes
Mar 21, 2019
3 tasks
jdumas
reviewed
Mar 21, 2019
jdumas
reviewed
Mar 21, 2019
Contributor
Author
|
Thanks @jdumas I think this is all set. Is there anything I still need to do? |
jdumas
requested changes
Apr 2, 2019
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay. I spotted two tinsy details that ought to be fixed, but then I believe it's good to go.
Contributor
Author
|
Hopefully that does it :) |
jdumas
reviewed
Apr 17, 2019
jdumas
approved these changes
Apr 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've extended igl::cat to accept a std::vector of matrices. I've also added a test case.
Also in this pull request: Template instantiations and a bug fix for adjacency_list (it wasn't working with std::vector).
Check all that apply (change to
[x])