Merged
Conversation
Contributor
Author
|
Release build fails due to timeout:
Is that a random occurrence or is it something I need to fix? |
Collaborator
|
Not really. That's something we need to work on, but unfortunately I don't have a lot of idea on how to improve build times on AppVeyor (there is no simple equivalent of In any case, either @alecjacobson or @danielepanozzo can still merge your PR even if the build timeout on AppVeyor. |
jdumas
approved these changes
Feb 22, 2019
danielepanozzo
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in libigl/libigl-stb#2:
Compiling igl_stb_image with gcc 7.3 (Ubuntu 18.04 LTS) with
-Wallcreates many warnings, likeThese warnings have been fixed upstream in stb_image and stb_image_write, thus I propose to update these files to their current versions from nothings/stb master. Compiling with these versions runs warnings-free.