Skip to content

Extend boundary_facets with outputs revealing which element facet comes from#1067

Merged
alecjacobson merged 2 commits intodevfrom
boundary-faces-extend
Feb 24, 2019
Merged

Extend boundary_facets with outputs revealing which element facet comes from#1067
alecjacobson merged 2 commits intodevfrom
boundary-faces-extend

Conversation

@alecjacobson
Copy link
Copy Markdown
Contributor

Also made some friendly sort overloads and fixed up some style things along the way. Corresponding unit tests.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@alecjacobson alecjacobson changed the base branch from master to dev December 28, 2018 20:19
@jdumas
Copy link
Copy Markdown
Collaborator

jdumas commented Feb 23, 2019

@alecjacobson compilation seems to fail on Windows on your PR (and this is not a timeout of AppVeyor).

missing windows template?
@alecjacobson alecjacobson merged commit 77eb3f8 into dev Feb 24, 2019
@jdumas jdumas deleted the boundary-faces-extend branch February 25, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants