Merged
Conversation
Collaborator
Author
|
Yes, it builds now! I've had to update a couple of third-party libraries (tetgen, triangle, stb_image, glad and comiso), but I've removed the hack around the |
This was referenced Nov 13, 2018
fwilliams
suggested changes
Nov 28, 2018
Collaborator
fwilliams
left a comment
There was a problem hiding this comment.
If I remember correctly, the old bindings work with python 2.7. Maybe change the shebangs to python instead of python3 so we don't break people running in an environment with 2.7.
Collaborator
Author
|
Blergh, who uses python 2 anymore nowadays ... |
fwilliams
approved these changes
Nov 28, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know we have new python bindings in the work, but right now the ones we have are not usable anymore.
LIBIGL_USE_STATIC_LIBRARY=ON, there will be missing symbols at runtime.shared.py.python/folder without the correct options.LIBIGL_USE_STATIC_LIBRARY=ONif they want to use the python bindings.target_link_libraries(pyigl PUBLIC igl::core), that meant properties ofigl::corewere not correctly propagated before (including-fPIC)../102_DrawMesh.pyTesting and integrating the new python bindings will take some time (a couple of weeks at least), so this needs to patched in the meantime.
Check all that apply (change to
[x])