Replies: 2 comments
-
|
I think this is a good idea. I wonder if this should be excised and re-written though. The templating on dimension for AABB has been a real pain and particularly when hitting this code point. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
We made some further testing and may found an additional bottleneck. So far we have: https://github.com/libigl/libigl/compare/main...svenpilz:reduceDynamicAllocations?expand=1 Would this be interesting as a pull-request for you? Edit: Added as #2001. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
(From: point_simplex_squared_distance)
Currently it uses
Eigen::Matrix<…, Eigen::Dynamic> b;, would it make sense to allow forEigen::Matrix<…, DerivedEle::ColsAtCompileTime> b;?From Eigen's documentation
As I read it, it would still fall back to
Eigen::Dynamic, but could useColsAtCompileTimewhich then would safe a memory allocation inlibigl/include/igl/point_simplex_squared_distance.cpp
Line 132 in 79dc4f6
AABB.I found this while profiling an Emscripten build with enabled multi-threading: emscripten-core/emscripten#15914.
Beta Was this translation helpful? Give feedback.
All reactions