diff: correct diff stat alignment in presence of renames w/ common prefix. #7057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi old friends!
I noticed that libgit2's diff stat has its alignment get thrown out in the presence of renames where there's a common prefix, e.g.:
This PR adds a test for this (fails on
main), and then fixes it by reproducing the common prefix detection when calculatinggit_diff_stats'smax_namemember. That now fully accounts for the various formats (i.e.samename,oldname => newname,prefix{oldsuffix => newsuffix}).This removed the sole use of
renamesin the same struct, so I dropped it.