refs: Handle normalizing negative refspecs #6951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative refspecs were added in Git v2.29.0 which allows refspecs to be prefixed with `^`[^1]. Currently, the library is unable to normalize negative refspecs which causes errors in different tools that rely on `libgit2`. Specifically, when the library attempts to parse and normalize a negative refspec, it returns a `GIT_EINVALIDSPEC` code. Add the ability to correctly normalize negative refspecs. While this PR will not update the behavior of `fetch`, or other actions that rely on negative refspecs, this allows us to be able to successfully parse and normalize them. A future change will handle updating the individual actions. [^1]: git/git@c0192df
d2fd5ae to
2adb7bc
Compare
Member
|
Seems reasonable - could you take a look at the failing existing test? I assume that it assumes that we don't support negative ref specs? |
Refs can now be prefixed with a ^ (indicating a negative ref). Remove a now-obsolete validity test.
Member
Nevermind - I fixed the test. Thanks for the addition to the library! |
Contributor
Author
|
Oops, I didn't realize I left a broken test. Thanks! Will work on updating the remote related code when I get a chance. |
Member
No worries! It was old unrelated code. I'd look forward to the remote code! Exciting stuff, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative refspecs were added in Git v2.29.0 which allows refspecs to be
prefixed with
^1. Currently, the library is unable to normalizenegative refspecs which causes errors in different tools that rely on
libgit2. Specifically, when the library attempts to parse andnormalize a negative refspec, it returns a
GIT_EINVALIDSPECcode.Add the ability to correctly normalize negative refspecs. While this PR
will not update the behavior of
fetch, or other actions that rely onnegative refspecs, this allows us to be able to successfully parse and
normalize them. A future change will handle updating the individual
actions.
#6741
Footnotes
https://github.com/git/git/commit/c0192df6306d4d9ad77f6015a053925b13155834 ↩