Skip to content

macOS GSS Support#5238

Merged
pks-t merged 4 commits intolibgit2:masterfrom
tiennou:feature/macos-gss
Oct 17, 2019
Merged

macOS GSS Support#5238
pks-t merged 4 commits intolibgit2:masterfrom
tiennou:feature/macos-gss

Conversation

@tiennou
Copy link
Contributor

@tiennou tiennou commented Sep 21, 2019

This is the needed changes to get the Apple GSS.framework used as a GSS provider on macOS (and only it, actually). This is completely untested, but as I managed to get deprecation warnings on #5237 it went downhill quickly.

Should fix #5230.

pks-t
pks-t reviewed Sep 21, 2019
View reviewed changes
Copy link
Member

@pks-t pks-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, certainly looks sensible. In addition to having an explicit "-DGSS_BACKEND" CMake option, I'd also love to see another commit that enables GSS support in our CI setups just so we know that it actually builds.

ethomson
ethomson reviewed Sep 21, 2019
View reviewed changes
@ethomson
Copy link
Member

ethomson commented Sep 21, 2019

Trying this, I get:

-- Could NOT find GSSAPI (missing: GSSAPI_LIBRARIES)
CMake Error at src/CMakeLists.txt:240 (INCLUDE):
  INCLUDE could not find load file:

    FindGSSFramework

@tiennou
Copy link
Contributor Author

tiennou commented Sep 21, 2019

Rebased, I've added the missing files, copyedited the backend selection, tested both methods locally, and added GSS to the macOS bots.

@jonathanturcotte jonathanturcotte mentioned this pull request Sep 26, 2019
Closed
@pks-t
Copy link
Member

pks-t commented Sep 27, 2019

CI still complains about not being able to find the SelectGSSAPI module :/

pks-t
pks-t reviewed Sep 27, 2019
View reviewed changes
pks-t
pks-t requested changes Oct 11, 2019
View reviewed changes
cmake/Modules/SelectGSSAPI.cmake
MESSAGE(FATAL_ERROR "Asked for gssapi GSS backend, but it wasn't found")
ENDIF()

LIST(APPEND LIBGIT2_LIBS ${GSSAPI_LIBRARIES})
Copy link
Member

@pks-t pks-t Oct 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't do so before, either, but we'd also need to adjust the include paths, right?
Edit: just to be clear, this is not a requirement to get your PR merged

@tiennou
Copy link
Contributor Author

tiennou commented Oct 13, 2019

Rebased. Note that it seems Xcode 11 dislikes something in how we setup on macOS — I can't clean-build master without a small fix since I upgraded, because I'm seeing this error

: No such file or directory: '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/CoreFoundation.framework'

even on master. I think the previous ld might have been more lenient by accepting an SDK path like this instead of the "standard" -framework CoreFoundation. I'll investigate and file a separate PR for that though.

@pks-t pks-t merged commit 0298e0a into libgit2:master Oct 17, 2019
@pks-t
Copy link
Member

pks-t commented Oct 17, 2019

Thanks a lot, @tiennou!

@tiennou tiennou deleted the feature/macos-gss branch December 6, 2019 20:58
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethomson ethomson ethomson left review comments

@pks-t pks-t pks-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't compile with GSSAPI enabled on macOS

3 participants

@tiennou @ethomson @pks-t