Skip to content

Add SecCopyErrorMessageString for iOS #6861

New issue
New issue
Closed
#6862
Closed
Add SecCopyErrorMessageString for iOS#6861
#6862
@Kyle-Ye

Description

@Kyle-Ye
Kyle-Ye
opened on Aug 17, 2024

SecCopyErrorMessageString is introduced to iOS since iOS 11.3 (29 March 2018)

https://developer.apple.com/documentation/security/1394686-seccopyerrormessagestring?language=objc

libgit2/src/libgit2/streams/stransport.c

Lines 29 to 38 in 4d38f13

#if !TARGET_OS_IPHONE
message = SecCopyErrorMessageString(ret, NULL);
GIT_ERROR_CHECK_ALLOC(message);
git_error_set(GIT_ERROR_NET, "SecureTransport error: %s", CFStringGetCStringPtr(message, kCFStringEncodingUTF8));
CFRelease(message);
#else
git_error_set(GIT_ERROR_NET, "SecureTransport error: OSStatus %d", (unsigned int)ret);
GIT_UNUSED(message);
#endif

This is a easy to fix issue. I'd like to file a PR to fix it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions