-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Description
Reproduction steps
Compile a program using #include <git2.h> and git_error_set_str.
Expected behavior
Program compiles successfully.
Actual behavior
error: ‘git_error_set_str’ was not declared in this scope; did you mean ‘giterr_set_str’?
Version of libgit2 (release number or SHA1)
1.8.0
Operating system(s) tested
Linux. I am not sure of the exact version. This was a flathub buildbot (log) (I think it uses CentOS).
Context
In #6625, git_error_set_str (along with some other functions) was moved from include/git2/errors.h to include/git2/sys/errors.h which is not included in the main include/git2.h. I noticed this while trying to rebuild KLayout with libgit2 1.8.0 which failed here (for reference, KLayout uses git_error_set_str here). I don't see git_error_set_str in the public API listed here but also don't see the removal mentioned in the 1.8.0 release notes, so I wondered if this was an oversight?
Sorry if I missed something obvious. I maintain the KLayout flatpak, but I am not a C++ developer.