Skip to content

libffi: added ARM64 support for Windows#462

Closed
ossdev07 wants to merge 0 commit intolibffi:masterfrom
ossdev07:master
Closed

libffi: added ARM64 support for Windows#462
ossdev07 wants to merge 0 commit intolibffi:masterfrom
ossdev07:master

Conversation

@ossdev07
Copy link
Copy Markdown
Contributor

@ossdev07 ossdev07 commented Dec 28, 2018

  1. ported sysv.S to win64_armasm.S for armasm64 assembler

  2. MSVC solution created with the changes, and below test suites are tested
    with test script written in python.

    libffi.bhaible
    libffi.call

  3. Basic functionality of above test suites are getting passed

Signed-off-by: ossdev ossdev@puresoftware.com

@ossdev07
Copy link
Copy Markdown
Contributor Author

ossdev07 commented Jan 2, 2019

@tromey can you please have a look on this patch ..
this is tested in my local setup but there are few system variables which are not set properly in this Travis environment that's why it did not run completely ..

@rth7680
Copy link
Copy Markdown
Contributor

rth7680 commented Jan 2, 2019

Why have you duplicated ffi.c? This should only require very minor changes for the changes MSVC makes for variadic functions. Use the GNU formatting style to match the rest of the project.

@ossdev07 ossdev07 force-pushed the master branch 6 times, most recently from eef3df2 to 112826e Compare January 3, 2019 11:48
@ossdev07
Copy link
Copy Markdown
Contributor Author

ossdev07 commented Jan 3, 2019

@rth7680 thanks for the review ..
PR has been updated after incorporating your review comments ..

@ossdev07
Copy link
Copy Markdown
Contributor Author

ossdev07 commented Jan 18, 2019 •
edited
Loading

@mbektchiev please merge these changes, as these changes are required for _ctype module in cpython(https://github.com/python/cpython),
I have tested _ctypes of cpython with these changes and its working fine.

@mbektchiev
Copy link
Copy Markdown
Contributor

mbektchiev commented Jan 21, 2019

@ossdev07 I'm sorry, but I'm not a committer in libffi and cannot merge them.

@ossdev07
Copy link
Copy Markdown
Contributor Author

ossdev07 commented Jan 22, 2019

can any maintainer have a look on this patch ..

@mbektchiev
Copy link
Copy Markdown
Contributor

mbektchiev commented Jan 22, 2019

From my previous experience, PRs are not closely monitored. I'd advise you to post an email to libffi-discuss at sourceware dot org in order to attract attention to your patch.

@atgreen
Copy link
Copy Markdown
Member

atgreen commented Feb 19, 2019

I'll commit your patch once you update the README with this new port. Thanks!

@ossdev07 ossdev07 force-pushed the master branch 4 times, most recently from f060b5a to 69de392 Compare February 20, 2019 04:35
@ossdev07
Copy link
Copy Markdown
Contributor Author

ossdev07 commented Apr 8, 2019

@atgreen commit #482 need to be merged for Linux aarch64.

@driver1998 driver1998 mentioned this pull request Apr 8, 2019
Closed
@ossdev07 ossdev07 closed this Apr 12, 2019
@ossdev07 ossdev07 mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ossdev07 @rth7680 @mbektchiev @atgreen