Support unix domain sockets in the http client [MERGED]#322
Closed
seanyoung wants to merge 1 commit intolibevent:masterfrom
seanyoung:unix-socket
Closed
Support unix domain sockets in the http client [MERGED]#322seanyoung wants to merge 1 commit intolibevent:masterfrom seanyoung:unix-socket
seanyoung wants to merge 1 commit intolibevent:masterfrom
seanyoung:unix-socket
Conversation
azat
reviewed
Apr 21, 2019
Member
azat
left a comment
There was a problem hiding this comment.
Hi @seanyoung
I like the changes in general, but they should be split into smaller patches (I count 3, evhttp_uri, server accepting changes, client making request changes)
Are you still interesting in this? If so, can you please split them?
P.S. and I'm very sorry for not paying attention before.
There are no standard for encoding a unix socket in an url. nginx uses: http://unix:/path/to/unix/socket:/httppath The second colon is needed to delimit where the unix path ends and where the rest of the url continues. Signed-off-by: Sean Young <sean@mess.org>
Contributor
Author
|
Please let me know if you want to split the commit when you come round to reviewing it in 2025. |
azat
approved these changes
Aug 10, 2021
Member
azat
left a comment
There was a problem hiding this comment.
Thanks!
I've addressed my comments, but I can't push to your topic branch, will apply the patch to upstream w/o updating PR then, and close PR after (so it will not have merged icon).
Member
|
Applied. Upstream commit is f446229. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no standard for encoding a unix socket in an url. nginx uses:
http://unix:/path/to/unix/socket:/httppath
The second colon is needed to delimit where the unix path ends and where
the rest of the url continues.