Open
Conversation
Fixes libevent#779. Signed-off-by: Harvey Tuch <htuch@google.com>
azat
reviewed
Oct 13, 2020
| #include <sys/socket.h> | ||
| #endif | ||
| #include <signal.h> | ||
| #include <stdatomic.h> |
Member
There was a problem hiding this comment.
This breaks windows build:
D:\a\libevent\libevent\signal.c(47): fatal error C1083: Cannot open include file: 'stdatomic.h': No such file or directory [D:\a\libevent\libevent\build\event_core_shared.vcxproj]
https://github.com/libevent/libevent/pull/1105/checks?check_run_id=1245032772#step:5:126
Author
There was a problem hiding this comment.
I don't currently have the ability to build on Windows, so not sure if I can help with this.
Contributor
|
microsoft explicitly excludes stdatomics from the list of supported features in their standard library. in mimalloc, the maybe the simplest solution is to do something similar? |
Member
|
Yes, this will work. @yogo1212 can you submit a PR? |
Closed
Member
|
Closed in favor of #1363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779.
Signed-off-by: Harvey Tuch htuch@google.com