BLD: fix an implicit conversion error (char[2] -> int)#155
Conversation
6b62c6e to
4d8830c
Compare
char[2] -> int)
4534bcf to
6f93a91
Compare
char[2] -> int)char[2] -> int)
6f93a91 to
e2a2d78
Compare
|
Ok I think I got it this time: wheel builds is green on macOS arm64. |
|
ping @mhvk for review |
mhvk
left a comment
There was a problem hiding this comment.
Thanks for finding that! Since get_liberfa_versions() actually returns the right types, it may make sense to just use that information, which would be a smaller change. Suggestions inline...
| print('Configure liberfa ("configure.ac" scan)') | ||
| lines = [] | ||
| for name, value in get_liberfa_versions(): | ||
| lines.append(f'#define {name} "{value}"') |
There was a problem hiding this comment.
I think this can be done more simply as,
if isinstance(value, str):
# strings should be escaped
value = f'"{value}"'
lines.append(f'#define {name} {value}')
Or, just accounting for the fact that repr gives the wrong type of quote,
lines.append(f'#define {name} {value!r}'.replace("'", '"'))
There was a problem hiding this comment.
neat. I just pushed your one-liner. Thanks !
e2a2d78 to
8d06124
Compare
|
Great, let's get this in! |
Tentatively fix a build error seen in CI
example logs
I couldn't reproduce this locally yet so fingers crossed.