Skip to content

Fix the new Connection.get_cursor method#82

Merged
Changaco merged 4 commits intomasterfrom
connection.get_cursor-fix
Oct 9, 2019
Merged

Fix the new Connection.get_cursor method#82
Changaco merged 4 commits intomasterfrom
connection.get_cursor-fix

Conversation

@Changaco
Copy link
Copy Markdown
Member

@Changaco Changaco commented Oct 8, 2019

I messed up in #73 and I forgot to update the method when I added support for subtransactions in #78. This branch fixes both of those mistakes.

@Changaco Changaco force-pushed the connection.get_cursor-fix branch from cc6dd24 to f174dd7 Compare October 8, 2019 11:54
@Changaco Changaco force-pushed the connection.get_cursor-fix branch from f174dd7 to 32bc5d4 Compare October 8, 2019 11:58
@Changaco
Copy link
Copy Markdown
Member Author

Changaco commented Oct 9, 2019

The remaining issue is that with conn.cursor() as cursor and with conn.get_cursor() as cursor are now both valid but behave differently: the latter commits or rolls back at the end whereas the former only closes the cursor.

@Changaco Changaco merged commit 297f4a4 into master Oct 9, 2019
@Changaco Changaco deleted the connection.get_cursor-fix branch October 9, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant