Add ZoneLister interface to list available zones (close #52)#98
Merged
mholt merged 2 commits intolibdns:masterfrom Feb 27, 2023
Merged
Add ZoneLister interface to list available zones (close #52)#98mholt merged 2 commits intolibdns:masterfrom
mholt merged 2 commits intolibdns:masterfrom
Conversation
This commit adds a new interface provider APIs can implement to list available zones that can be used with the other interfaces provided by libdns. Co-authored-by: Anders Pitman <7820200+anderspitman@users.noreply.github.com>
mholt
previously approved these changes
Feb 24, 2023
Contributor
mholt
left a comment
There was a problem hiding this comment.
LGTM! I just had a few minor nits about the godoc 🙃
Thanks for the contribution.
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
mholt
approved these changes
Feb 27, 2023
Contributor
mholt
left a comment
There was a problem hiding this comment.
Beautiful -- let's throw it at the wall and see if it sticks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new interface provider APIs can implement to list available zones that can be used with the other interfaces provided by libdns.