Merged
Conversation
Some implementations implement `SetRecords` and `AppendRecords` identically, but this is incorrect. This commit updates the `SetRecords` documentation to clarify that `SetRecords` can only be implemented by a combination of `DeleteRecords` and `AppendRecords`, not `AppendRecords` alone. Fixes libdns#186.
mholt
approved these changes
Aug 13, 2025
Contributor
mholt
left a comment
There was a problem hiding this comment.
Thanks! As usual, this is more thorough than I would have done myself, haha. But I think this is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some implementations implement
SetRecordsandAppendRecordsidentically, but this is incorrect. This commit updates theSetRecordsdocumentation to clarify thatSetRecordscan only be implemented by a combination ofDeleteRecordsandAppendRecords, notAppendRecordsalone.Fixes #186.