remove internal reallocarray()#201
Merged
anakryiko merged 1 commit intolibbpf:masterfrom Sep 30, 2020
Merged
Conversation
10 tasks
Member
|
libbpf doesn't require check-reallocarray.sh anymore, would you mind instead just removing it? |
Contributor
Author
|
I certainly wouldn't mind. I ran into 0.1.0 failing due to |
Member
|
@vcunat, do you plan to do a follow up and remove check-reallocarray.sh altogether? |
Contributor
Author
|
Ah, I thought you/someone planned to do it, but now I see that it wasn't clear from your post. So, I did not plan it, but I think I could do it within a couple days. |
aea1adb to
793a82d
Compare
Contributor
Author
|
I expect you wanted something like this? |
... as it's covered by libbpf_reallocarray() since commit dc70da9.
793a82d to
47147bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference, we ran into this problem due to strict sandboxing in a packaging solution.... as it's covered by libbpf_reallocarray() since commit dc70da9.