bsdtar: Disallow multiple --files-from/-T options#2607
Merged
kientzle merged 1 commit intolibarchive:masterfrom May 16, 2025
Merged
bsdtar: Disallow multiple --files-from/-T options#2607kientzle merged 1 commit intolibarchive:masterfrom
kientzle merged 1 commit intolibarchive:masterfrom
Conversation
kientzle
approved these changes
May 16, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple
--files-from/-Toptions are specified, only the last one is handled and the rest are silently discarded. We should implement this, but for now let's fail fast and disallow such invocations.GNU tar supports multiple
--files-from/-Toptions and they are positional - The ordering affects where the entries are placed in the output. I have done some black-box testing of GNU tar, and will discuss my findings in a separate issue.