Run staticcheck on all GOOS/GOARCH combinations; fix build on 32bit systems, Windows, and Plan9#1253
Conversation
2ddc54d to
6b3f837
Compare
Overflows on 32bit systems so you get a compile error.
Guess that didn't quite get renamed right and since CI is only tested on Linux I never noticed. Fixes #1251
Ideally tests should also run on at least some of these platforms (macOS, Windows), but I couldn't really get PostgreSQL to work in GitHub Actions. But at least test that it compiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally tests should also run on at least some of these platforms (macOS, Windows), but I couldn't really get PostgreSQL to work in GitHub Actions. But at least test that it compiles.
Also fix build on 32bit systems, Windows, and Plan 9.