[crm]: Ignore unsupported/non-implemented switch attributes (sonic-net#1613)

PrabhuSreenivasan · web-flow · commit bbd2ca6302fb · 2021-01-28T08:57:22.000-08:00
Signed-off-by: Prabhu Sreenivasan &lt;prabhu.sreenivasan@broadcom.com&gt;
diff --git a/orchagent/crmorch.cpp b/orchagent/crmorch.cpp
@@ -457,10 +457,15 @@ void CrmOrch::getResAvailableCounters()
                 sai_status_t status = sai_switch_api->get_switch_attribute(gSwitchId, 1, &attr);
                 if (status != SAI_STATUS_SUCCESS)
                 {
-                    if(status == SAI_STATUS_NOT_SUPPORTED)
+                    if((status == SAI_STATUS_NOT_SUPPORTED) ||
+                       (status == SAI_STATUS_NOT_IMPLEMENTED) ||
+                       SAI_STATUS_IS_ATTR_NOT_SUPPORTED(status) ||
+                       SAI_STATUS_IS_ATTR_NOT_IMPLEMENTED(status))
                     {
                         // remove unsupported resources from map
                         m_resourcesMap.erase(res.first);
+                        SWSS_LOG_NOTICE("Switch attribute %u not supported", attr.id);
+                        break;
                     }
                     SWSS_LOG_ERROR("Failed to get switch attribute %u , rv:%d", attr.id, status);
                     break;

Original file line number	Diff line number	Diff line change
`@@ -457,10 +457,15 @@ void CrmOrch::getResAvailableCounters()`
`457`	`457`	`sai_status_t status = sai_switch_api->get_switch_attribute(gSwitchId, 1, &attr);`
`458`	`458`	`if (status != SAI_STATUS_SUCCESS)`
`459`	`459`	`{`
`460`		`- if(status == SAI_STATUS_NOT_SUPPORTED)`
	`460`	`+ if((status == SAI_STATUS_NOT_SUPPORTED) \|\|`
	`461`	`+ (status == SAI_STATUS_NOT_IMPLEMENTED) \|\|`
	`462`	`+ SAI_STATUS_IS_ATTR_NOT_SUPPORTED(status) \|\|`
	`463`	`+ SAI_STATUS_IS_ATTR_NOT_IMPLEMENTED(status))`
`461`	`464`	`{`
`462`	`465`	`// remove unsupported resources from map`
`463`	`466`	`m_resourcesMap.erase(res.first);`
	`467`	`+ SWSS_LOG_NOTICE("Switch attribute %u not supported", attr.id);`
	`468`	`+ break;`
`464`	`469`	`}`
`465`	`470`	`SWSS_LOG_ERROR("Failed to get switch attribute %u , rv:%d", attr.id, status);`
`466`	`471`	`break;`