Skip to content

Fix tests execution when using recent rebar3 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rvirding merged 1 commit into from
Jul 2, 2024
Merged

Fix tests execution when using recent rebar3 #491

rvirding merged 1 commit into from
Jul 2, 2024

Conversation

@delitrem
Copy link
Contributor

@delitrem delitrem commented Jun 26, 2024

This fixes the following:

% rebar3 --version                                            
rebar 3.23.0 on Erlang/OTP 27 Erts 15.0
% make tests 
[...]
===> Compiling lfe
===> Testing prop_lfe_docs:prop_define_lambda()
Error: Unrecognized option: {task,[50,48,44,99,116]}.
===> Testing prop_lfe_docs:prop_define_match()
Error: Unrecognized option: {task,[50,48,44,99,116]}.
===> 
0/2 properties passed, 2 failed
===> Failed test cases:
prop_lfe_docs:prop_define_lambda() -> {error,
                                       {unrecognized_option,{task,"20,ct"}}}
prop_lfe_docs:prop_define_match() -> {error,
                                      {unrecognized_option,{task,"20,ct"}}}
make: *** [Makefile:199: tests] Error 1

@delitrem delitrem mentioned this pull request Jul 1, 2024
Closed
@rvirding
Copy link
Member

rvirding commented Jul 2, 2024

OK it works for my

rebar 3.20.0 on Erlang/OTP 26 Erts 14.2.5

And the space after the -n 20, ct as well. Strange you need the space.

@delitrem
Copy link
Contributor Author

delitrem commented Jul 2, 2024

OK it works for my

rebar 3.20.0 on Erlang/OTP 26 Erts 14.2.5

Yes, it works fine with rebar3 upto version 3.22.1, but not with 3.23.0, which seems to introduce some backward compatibility breakage.

@rvirding rvirding merged commit 15a70df into lfe:develop Jul 2, 2024
@chenrui333 chenrui333 mentioned this pull request Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@delitrem @rvirding