Skip to content

Conversation

@chenrui333
Copy link
Contributor

ld: unknown options: --as-needed

ldflag --as-needed does not exist for clang

relates to Homebrew/homebrew-core#159023

```
ld: unknown options: --as-needed
```

Signed-off-by: Rui Chen <rui@chenrui.dev>
@oubiwann
Copy link
Member

oubiwann commented Jan 6, 2024

Thanks!

@chenrui333
Copy link
Contributor Author

thanks for the approval, any blocker of merging this change? (we have shipped in the homebrew side for this patch)

@oubiwann
Copy link
Member

oubiwann commented Jan 7, 2024

@chenrui333 no blocker! We just want to make sure @rvirding has a chance to approve 😄

@rvirding rvirding merged commit c97a44f into lfe:develop Jan 8, 2024
@rvirding
Copy link
Member

rvirding commented Jan 8, 2024

OK, I have merged this into develop and then merged it into master. The question is whether I should "move" the 2.1.3 tag or just leave it? I don't really want to create a new tag just for this.

@chenrui333
Copy link
Contributor Author

OK, I have merged this into develop and then merged it into master. The question is whether I should "move" the 2.1.3 tag or just leave it? I don't really want to create a new tag just for this.

we should do roll forward (ie creating a new release) rather than re-tagging.

@oubiwann
Copy link
Member

oubiwann commented Jan 8, 2024

Excellent! I can re-tag and re-release today!

@oubiwann
Copy link
Member

oubiwann commented Jan 8, 2024

(by which I mean 2.1.4 ...)

@oubiwann
Copy link
Member

oubiwann commented Jan 9, 2024

sorry, meant to give an update here: that was done yesterday ... tagged/released on GH, uploaded to hex.pm, and updated the lfe.io "Download" options to point there, too.

@chenrui333
Copy link
Contributor Author

Thanks @oubiwann!

@chenrui333
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants