Skip to content

Conversation

@yastanotheruser
Copy link
Contributor

The exp_comp function was updated to bind operands to variables and then compare the variables in successive pairs. Fixes #445.

@rvirding
Copy link
Member

rvirding commented May 24, 2023

Have you any more changes you would like to make? I have one suggestion and that is don't import lists:zip and lists:droplast but call them with the module explicitly. I am slowly migrating away from importing functions from modules to being explicit in the code.

@yastanotheruser
Copy link
Contributor Author

nope, looks okay

@rvirding rvirding merged commit 0985540 into lfe:develop Jun 9, 2023
@rvirding
Copy link
Member

rvirding commented Jun 9, 2023

This seems to work as it should but the checks on OTP 19/20/21 haven't been run. I don't know why.

@oubiwann
Copy link
Member

@rvirding looking into CI/CD now ...

@oubiwann
Copy link
Member

@rvirding I opened a ticket for this here: #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

== macro expansion is incorrect

3 participants