Remove duplicate entries from EBINS #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfe_scan.xrl will get compiled to lfe_scan.erl during make compile, which in turn will be compiled to lfe_scan.beam. Since EBINS contains all the .erl and .xrl files with the ending replaced by .beam it will contain lfe_scan.beam twice when executing make install which may cause an error on execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a cherry-pick from this old PR by @Beji (which was too old to merge):
Commit message:
lfe_scan.xrl will get compiled to lfe_scan.erl during make compile,
which in turn will be compiled to lfe_scan.beam.
Since EBINS contains all the .erl and .xrl files with the ending
replaced by .beam it will contain lfe_scan.beam twice when executing
make install which may cause an error on execution.
Original PR description follows ...
Hi,
as mentioned on #342 make install fails on my gentoo system because make install tries to install lfe_scan.beam twice.
During the whole compilation magic src/lfe_scan.xrl will get turned into src/lfe_scan.erl . As EBINS is essentially a list of all .erl, .xrl and .yrl files with the endings replaced by .beam this results in the problem that EBINS will contain lfe_scan.beam twice as this name is generated from both the .xrl and the .erl file. As this problem seems to affect the install target I tried not to mess with anything else (I don't know a lot about make).
This fix is kinda ugly but it resolves the issue for me. Not sure if this will work well on other systems but it might be worth a shot.