Skip to content

feat: run commands on host w/o spawning a tty#24

Merged
lfaoro merged 6 commits intolfaoro:mainfrom
vybraan:feat/runcommands
Jul 29, 2025
Merged

feat: run commands on host w/o spawning a tty#24
lfaoro merged 6 commits intolfaoro:mainfrom
vybraan:feat/runcommands

Conversation

@vybraan
Copy link
Copy Markdown
Collaborator

@vybraan vybraan commented Jul 25, 2025 •
edited
Loading

added cmdModel in runcmd.go to handle remote command execution
ctrl+r now opens the command runner view
targeting #9

vybraan added 2 commits June 27, 2025 16:11
@vybraan
chore: clean up unused variable
ad07bb0
@vybraan
feat(tui): implement cmd execution ui
8a31d0c 
added interactive command runner for selected host with ctrl+r
@lfaoro
Copy link
Copy Markdown
Owner

lfaoro commented Jul 27, 2025

this is awesome! thank you @vybraan -- will check it locally and merge

@vybraan
Copy link
Copy Markdown
Collaborator Author

vybraan commented Jul 28, 2025

this is awesome! thank you @vybraan -- will check it locally and merge

thanks @lfaoro! let me know if anything should be improved

@lfaoro
Copy link
Copy Markdown
Owner

lfaoro commented Jul 28, 2025

this is awesome! thank you @vybraan -- will check it locally and merge

thanks @lfaoro! let me know if anything should be improved

yes, a little thing if you don't mind: the cursor is not shown to hint the user they can start typing.

also, the interface doesn't seem to resize when one resizes the terminal window.

just details though, works splendid!
Screenshot from 2025-07-28 18-40-28

@lfaoro
Copy link
Copy Markdown
Owner

lfaoro commented Jul 28, 2025

another thing I noticed is when there is an error the output is cleared, then typing another command that works the output is restored but without the error.
image
can test by doing: ctrl+r > w > top (should err| no term set) > w

@lfaoro
Copy link
Copy Markdown
Owner

lfaoro commented Jul 28, 2025

made a PR to your fork/branch that fixes the cursor try it and if you like it merge it, I believe the commit will appear in this PR

https://github.com/vybraan/ssm/pull/1/files

@lfaoro lfaoro self-assigned this Jul 28, 2025
@lfaoro lfaoro added the enhancement New feature or request label Jul 28, 2025
@lfaoro lfaoro linked an issue Jul 28, 2025 that may be closed by this pull request
feat: run commands on host w/o spawning a tty #9
Closed
@vybraan
Copy link
Copy Markdown
Collaborator Author

vybraan commented Jul 29, 2025

understood.
well, the error output i had deliberately cleared them. will work on it

lfaoro added 3 commits July 29, 2025 07:22
@lfaoro @vybraan
fix cursor update
f989f87 
the cursor wasn't showing, setting the virtual cursor will show it but
it won't update unless we update the model so now we're updating the
input model on every tea.loop
@lfaoro @vybraan
fix input/viewport resizing
04ed4da
@lfaoro @vybraan
allow users to run commands on hosts that require password auth
3f44efb
@vybraan vybraan mentioned this pull request Jul 29, 2025
Closed
@lfaoro lfaoro merged commit 6767aac into lfaoro:main Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lfaoro lfaoro

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: run commands on host w/o spawning a tty

2 participants

@vybraan @lfaoro