do not send git log stdout to debug logs anymore. too much noise.#155
do not send git log stdout to debug logs anymore. too much noise.#155levibostian merged 1 commit intomainfrom
Conversation
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🌴 It will not trigger a deployment. No new version will be deployed. Learn moreLatest release: 0.12.0 Commit of latest release: 7a66814 Commits since last release: - do not send git log stdout to debug logs anymore. too much noise. Related GitHub Issues<!-- Link to any related GitHub issues that this pull request addresses or closes. --> Problem<!-- A clear description of the problem that this pull request is solving. -->
Solution<!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> Because this is a one-off case for the logger and we dont want to modify any other command behavior, add an optional parameter to exec.run that changes this behavior. So the default behavior doesn't change. Testing<!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. -->
Going to turn on debug mode for this PR and see if it works as expected. Notes for reviewers<!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. --> ...🟩 rebase 🟩 merge method... 🌴 It will not trigger a deployment. No new version will be deployed. Learn moreLatest release: 0.12.0 Commit of latest release: 7a66814 Commits since last release: - do not send git log stdout to debug logs anymore. too much noise. |
|
Checked the circle logs, which have debug enabled at all times, and the output looked good. All commands seem to still send stdout/stderr to console except for git log. |
Related GitHub Issues
Problem
git logoutput is just wayyyyy too noisey. It has made debugging difficult to do. Sure, there can be an error in the git log command. if there is, I think we can make something like a script that you install that runs for the 'get latest release' step that logs all parsed commits and that will help debug git commits that were incorrectly parsed.Solution
Because this is a one-off case for the logger and we dont want to modify any other command behavior, add an optional parameter to exec.run that changes this behavior. So the default behavior doesn't change.
Testing
Going to turn on debug mode for this PR and see if it works as expected.
Notes for reviewers