Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: levibostian/decaf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.8.0
Choose a base ref
...
head repository: levibostian/decaf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.9.0
Choose a head ref
  • 13 commits
  • 19 files changed
  • 2 contributors

Commits on Dec 17, 2025

  1. refactor: replace jsr:deno-library/template with npm:ventojs for stri…

    …ng template engine
    
    deno-library/template doesn't offer support for loops and I'll be needing that allowing users to provide a custom PR comment.
    
    I chose vento because...
    - very similar syntax to deno-library/template (using {{...}}) to be simple and easy to use.
    - gives more powerful features like loops, conditionals.
    - zero dependencies. small. simple.
    levibostian committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    3d08b6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c778541 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9e4cc5 View commit details
    Browse the repository at this point in the history
  4. refactor: document usage of ventojs for later reference

    to help devs + agents learn ventojs quickly, putting documentation in the code via comments with basic usage.
    levibostian committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    8f8f897 View commit details
    Browse the repository at this point in the history
  5. completely replace contents of PR comment each time, dont append

    Because we're using string templates now, we don't want to use the appending feature of appending context to the existing PR comment. We want to completely replace it instead, just because then you don't have to add a bunch of logic to your string template.
    levibostian committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    ac88dce View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f1a7105 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    814e6b4 View commit details
    Browse the repository at this point in the history
  8. fix: escape the pull request template string

    When you pass in the template string as a param, there's a good chance that it uses different kinds of quotes inside of it, which then messes with the CLI Bash command that we're running, where we're trying to pass the string into decaf. So, as a way to properly escape that string you pass in, we write to a temporary file and then just pass that file to decaf.
    levibostian committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    2123eb5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f0cb47d View commit details
    Browse the repository at this point in the history
  10. improve error message when ventojs is given an invalid template

    The original error message I got when running the code in the CI was talking about regex, which is super confusing when I wasn't passing regex at all.
    
    So, I just think we need to have a better error message in general to help if users encounter a problem.
    levibostian committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    f43d182 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ec7c774 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c3ec1b3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0621668 View commit details
    Browse the repository at this point in the history
Loading