Skip to content

Bug: Include hostPortString in the error message#876

Closed
LarryBattle wants to merge 1 commit intoredis:masterfrom
LarryBattle:master
Closed

Bug: Include hostPortString in the error message#876
LarryBattle wants to merge 1 commit intoredis:masterfrom
LarryBattle:master

Conversation

@LarryBattle
Copy link
Copy Markdown
Contributor

The host and port wasn't included in the error message for Invalid bracketed host/port due to a missing %s.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2018

Codecov Report

Merging #876 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #876      +/-   ##
===========================================
- Coverage     81.11%   81.1%   -0.01%     
+ Complexity     5690    5686       -4     
===========================================
  Files           409     409              
  Lines         18385   18385              
  Branches       2128    2128              
===========================================
- Hits          14913   14912       -1     
  Misses         2462    2462              
- Partials       1010    1011       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/lettuce/core/internal/HostAndPort.java 91.89% <100%> (ø) 32 <0> (ø) ⬇️
...uce/core/masterslave/SentinelTopologyProvider.java 80.55% <0%> (-2.78%) 9% <0%> (-1%)
...tuce/core/masterslave/SentinelTopologyRefresh.java 83.55% <0%> (-1.32%) 33% <0%> (-2%)
...lettuce/core/internal/AsyncConnectionProvider.java 83.95% <0%> (-1.24%) 15% <0%> (-1%)
src/main/java/io/lettuce/core/RedisPublisher.java 79.92% <0%> (ø) 5% <0%> (ø) ⬇️
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 83.91% <0%> (+2.09%) 40% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c682f...cc52496. Read the comment docs.

@mp911de mp911de added the type: bug A general bug label Oct 8, 2018
@mp911de mp911de added this to the 5.1.1 milestone Oct 8, 2018
mp911de added a commit that referenced this pull request Oct 8, 2018
Fix other formatted messages with arguments. Add author tag.
mp911de added a commit that referenced this pull request Oct 8, 2018
Fix other formatted messages with arguments. Add author tag.
mp911de added a commit that referenced this pull request Oct 8, 2018
Fix other formatted messages with arguments. Add author tag.
mp911de added a commit that referenced this pull request Oct 8, 2018
Fix other formatted messages with arguments. Add author tag.
mp911de added a commit that referenced this pull request Oct 8, 2018
Fix other formatted messages with arguments. Add author tag.
@mp911de
Copy link
Copy Markdown
Collaborator

mp911de commented Oct 8, 2018

Thanks a lot. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants