Bind issuers to only issue for specified profiles #8409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
requested changes
Sep 29, 2025
Contributor
jsha
left a comment
There was a problem hiding this comment.
Generally looks good! Some small comments.
fb42e7f to
a1e2343
Compare
e400019 to
95946c2
Compare
a1e2343 to
8337e76
Compare
95946c2 to
8934226
Compare
8337e76 to
acfe975
Compare
beautifulentropy
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how the CA determines which issuer to use (the
pickIssuerhelper), to take into account the requested profile alongside the CSR's key algorithm. This simple loop allows us to greatly simplify how the CA has to track its set of issuers, resulting in some wider-reaching changes to the NewCertificateAuthorityImpl constructor, the unit tests, and boulder-ca/main.go.Make the recently-added Issuer.Profiles config field required, and add checks to ensure that all profiles are listed by at least one issuer, and that all profiles listed by an issuer are actually configured.
Fixes #8390
Warning
Do not merge before #8424Do not merge before #8423 has been deployedDo not merge before IN-11840 has been completed