Remove support for temporally-sharded CRLs #8400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2025
jsha
approved these changes
Sep 22, 2025
jprenken
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crl-updater, delete the code which computes the set of temporal chunks that belong to a shard, which queries the database for revoked certs falling into those chunks, and which combines and deduplicates those results against the revoked certs from explicit shards.
In the SA, make the ShardIdx argument to RevokeCertificate and UpdateRevokedCertificate fully mandatory, and make updating the revokedCertificates table unconditional.
This paves the way for deleting the sa.GetMaxExpiration and sa.GetRevokedCerts methods, which were only called from code deleted by this change.
IN-11747 tracks the corresponding config change in prod.
Part of #8399
Part of #8322