ratelimits: Fix transaction building for Failed Authorizations Limit#7344
Merged
Conversation
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
6471d3d to
cd1b41b
Compare
288d159 to
3a6a21e
Compare
pgporada
previously approved these changes
Feb 29, 2024
pgporada
approved these changes
Mar 1, 2024
aarongable
approved these changes
Mar 5, 2024
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo one optional comment
Member
Author
I have informed SRE of the configuration changes made in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FailedAuthorizationsPerAccountenum toFailedAuthorizationsPerDomainPerAccountto align with its corrected implementation. This change is possible because the limit isn't yet deployed in staging or production.Blocks #7346
Part of #5545