WFE: Two changes to NewRegistration key-value rate limits#7258
Merged
Conversation
18 tasks
pgporada
approved these changes
Jan 12, 2024
pgporada
previously approved these changes
Jan 12, 2024
aarongable
reviewed
Jan 12, 2024
28ae482 to
1c908ce
Compare
1c908ce to
7ad61fd
Compare
9d21e51 to
5d19c16
Compare
5d19c16 to
5f32b90
Compare
aarongable
approved these changes
Jan 17, 2024
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one optional improvement.
| defer func() { | ||
| if !newRegistrationSuccessful { | ||
| go wfe.refundNewAccountLimits(ctx, ip) | ||
| if !newRegistrationSuccessful && !errIsRateLimit { |
Contributor
There was a problem hiding this comment.
I know you didn't touch the newRegistrationSuccessful bool in this PR, so feel free to ignore me, but could this become
if err != nil && !errors.Is(err, berrors.RateLimit) {
? Rather than carrying around these two bools, I think the conditional can be computed here from variables we already have access to.
pgporada
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make NewRegistration more consistent with the implementation in NewOrder (#7201):
Part of #5545