grpc/sa: Implement deep health checks#6928
Conversation
0074147 to
5f34810
Compare
5f34810 to
d8cb2ff
Compare
I thought I understood this, but I don't yet.
|
@pgporada and I had a call to chat through his questions. |
|
Took some screenshots and ran through a few scenarios so folks are clear on how this is going to work:
The DB and ProxySQL are both up, everything is green: If you take down ProxySQL (or the DB), sa and saro are red, but grpc is green: If you remove the If you remove the |
aarongable
left a comment
There was a problem hiding this comment.
Mostly tiny code organization comments. Last top-level comment: it would be great to have a unittest that tests the check closure: sets up a health server, supplies a tiny fake health check function, and ensures that the health server's status was updated appropriately. This may require busting check all the way out to being a method on serverBuilder or something like that, rather than being a closure =/
Add the necessary scaffolding for deep health checking of our various gRPC components. Each component implementation that also implements the grpc.checker interface will be checked periodically, and the health status of the component will be updated accordingly.
Add the necessary methods to SA to implement the grpc.checker interface and register these new health checks with Consul.
Additionally:
Fixes #6878
Part of #6795