Skip to content

P164 gases ens160 #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TD-er merged 19 commits into from
Feb 3, 2024
Merged

P164 gases ens160 #4910

TD-er merged 19 commits into from
Feb 3, 2024

Conversation

@flashmark
Copy link
Contributor

@flashmark flashmark commented Dec 11, 2023

Adding P164 gasses ENS16x measuring eCO2 & TVOC.
Code is based upon Sciosense Arduino code from Github and adapted to ESPeasy concepts.
The code should work on both ENS160 and ENS161 devices. I can test ENS160 only.

tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
TD-er
TD-er requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@TD-er TD-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first quick scan over the PR.
But since I kept seeing the same issue, please fix these things first.

Just don't write to Serial for logs,
Rather use addLog(LOG_LEVEL_INFO, F("...")); or LOG_LEVEL_ERROR

tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 11, 2023
View reviewed changes
@tonhuisman tonhuisman mentioned this pull request Dec 11, 2023
Open
tonhuisman
tonhuisman suggested changes Dec 12, 2023
View reviewed changes
TD-er
TD-er reviewed Dec 27, 2023
View reviewed changes
TD-er
TD-er reviewed Dec 27, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 28, 2023
View reviewed changes
tonhuisman
tonhuisman reviewed Dec 28, 2023
View reviewed changes
@tonhuisman
Copy link
Contributor

tonhuisman commented Dec 28, 2023

You haven't yet included USES_P164 in both define_plugin_sets.h and Custom-sample.h.

I think this one should be included in Collection G and MAX builds, and probably in the Climate builds, (not sure if will fit in the ESP8266 builds though).

@flashmark
Copy link
Contributor Author

flashmark commented Dec 28, 2023

Added P164 ENS16x to Collection G and Climate. As far as I understand the structure all Collection G plugins will be included in MAX. Collection G and Climate do compile and run on ESP8266.

@flashmark flashmark requested a review from TD-er January 15, 2024 19:59
@flashmark
Copy link
Contributor Author

flashmark commented Feb 3, 2024

I tried to merge some files, but I don't understand how Github can update my branch such that I can finish this pull request. Code is running fine and last review comments are processed.

tonhuisman
tonhuisman reviewed Feb 3, 2024
View reviewed changes
@tonhuisman
Copy link
Contributor

tonhuisman commented Feb 3, 2024

Only TD-er can merge pull requests, so we'll wait for that. 😺

@TD-er
Copy link
Member

TD-er commented Feb 3, 2024

Mergeconflict resolved

@TD-er TD-er merged commit 438ef4f into letscontrolit:mega Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TD-er TD-er Awaiting requested review from TD-er

1 more reviewer

@tonhuisman tonhuisman tonhuisman requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flashmark @tonhuisman @TD-er