Skip to content

Issue3115 ext in node path#3120

Merged
matthew-dean merged 4 commits into
less:3.xfrom
robhuzzey:issue3115_extInNodePath
Oct 20, 2017
Merged

Issue3115 ext in node path#3120
matthew-dean merged 4 commits into
less:3.xfrom
robhuzzey:issue3115_extInNodePath

Conversation

@robhuzzey

Copy link
Copy Markdown
Contributor

This should fix issue: #3115 & I'm hoping a few of the other issues I have seen around paths & webpack?

@matthew-dean

Copy link
Copy Markdown
Member

Looks good, thanks!

@matthew-dean matthew-dean merged commit 8d6204c into less:3.x Oct 20, 2017
@matthew-dean

Copy link
Copy Markdown
Member

@robhuzzey Since you had a little trouble understanding how to do this in Less for the first time, is there anything that could be added or improved to make contributing to Less easier for yourself or others in the future?

@robhuzzey

Copy link
Copy Markdown
Contributor Author

Thanks @matthew-dean yes, I didn't fully understand that each .less file was a test & also needed a .css file to test against.

It's really obvious to me now, but just adding a line of two in the Docs pointing that out would have really helped me out :)

I'm happy to do this if I have a little time later, although I'm not sure if it lives in here: http://lesscss.org/usage/#developing-less or here: https://github.com/less/less.js/blob/3.x/CONTRIBUTING.md

@robhuzzey robhuzzey deleted the issue3115_extInNodePath branch October 22, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants