fix(version): create release when using custom tag-version-separator#3979
Merged
JamesHenry merged 1 commit intolerna:mainfrom Apr 1, 2024
Merged
fix(version): create release when using custom tag-version-separator#3979JamesHenry merged 1 commit intolerna:mainfrom
JamesHenry merged 1 commit intolerna:mainfrom
Conversation
ghiscoding
reviewed
Mar 21, 2024
JamesHenry
approved these changes
Apr 1, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bbdc78a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
Member
|
Thank you very much! |
Merged
9 tasks
Contributor
Author
|
@JamesHenry do you know when the next release might be? Looking forward to getting this fix out so I can use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the 8.1.0, the version command does not create a GitHub release when using a custom version seperator. This was because the
createReleasefunction had a hard coded@in tag name filter.Motivation and Context
Fixes: #3974
How Has This Been Tested?
To test, I create a test repo made changes to a packages and commit them. I then ran:
And was able to see the new GitHub release created with the appropriate tag
Types of changes
Checklist: