Skip to content

chore: update npmlog types#3913

Merged
JamesHenry merged 2 commits intolerna:mainfrom
amorscher:ts-fixes-npmlog
Dec 20, 2023
Merged

chore: update npmlog types#3913
JamesHenry merged 2 commits intolerna:mainfrom
amorscher:ts-fixes-npmlog

Conversation

@amorscher
Copy link
Copy Markdown
Contributor

use correct type definitions

Description

Motivation and Context

avoid as any

How Has This Been Tested?

all tests still pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Nov 30, 2023

Copy link
Copy Markdown
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry has lock file conflicts

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Dec 15, 2023

@amorscher amorscher requested a review from JamesHenry December 15, 2023 15:54
@amorscher
Copy link
Copy Markdown
Contributor Author

@JamesHenry should be fine now

Copy link
Copy Markdown
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JamesHenry JamesHenry merged commit adea20e into lerna:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants