fix(version): update lock files after the version hook#3849
Merged
fahslaj merged 2 commits intolerna:mainfrom Oct 10, 2023
Merged
fix(version): update lock files after the version hook#3849fahslaj merged 2 commits intolerna:mainfrom
fahslaj merged 2 commits intolerna:mainfrom
Conversation
Contributor
Author
|
@fahslaj the CI failed in a non-related test it seems 🤔 |
fahslaj
approved these changes
Oct 10, 2023
Contributor
|
Thanks @matheo ! |
Contributor
Author
|
Thanks @fahslaj any ETA for the release? |
Contributor
|
No specific ETA yet, but we are working on a minor release that will hopefully be out early this coming week. |
Contributor
|
@matheo this was just released with version 7.4.0 |
Contributor
Author
|
@fahslaj Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now the lock-file is updated before the root
versionscript, but if we edit some custom stuff in that hook (withlerna exec --sincethen it won't be possible to include those changes in the lock file and that seems undesirable.How Has This Been Tested?
Tested locally with a custom hook updating the package.json files of the changed packages.
Types of changes
Checklist: