Skip to content

fix(run): only defer to Nx when targetDefaults are defined in nx.json#3349

Merged
vsavkin merged 3 commits intolerna:mainfrom
fahslaj:check-nxjson-contents
Sep 29, 2022
Merged

fix(run): only defer to Nx when targetDefaults are defined in nx.json#3349
vsavkin merged 3 commits intolerna:mainfrom
fahslaj:check-nxjson-contents

Conversation

@fahslaj
Copy link
Copy Markdown
Contributor

@fahslaj fahslaj commented Sep 29, 2022

Change lerna run to only pass target dependencies to Nx when there are not target defaults already defined in nx.json

Description

Motivation and Context

Follow up / partial reversion of:
#3345

How Has This Been Tested?

This has been covered by e2e tests for the run command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the check-nxjson-contents branch from a375839 to 4766a3f Compare September 29, 2022 19:38
@fahslaj fahslaj marked this pull request as ready for review September 29, 2022 20:01
@vsavkin vsavkin merged commit 51f80d9 into lerna:main Sep 29, 2022
@fahslaj fahslaj deleted the check-nxjson-contents branch September 29, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants