feat(version): add from-package bump option#3097
Closed
luwes wants to merge 1 commit intolerna:mainfrom
luwes:version-from-package
Closed
feat(version): add from-package bump option#3097luwes wants to merge 1 commit intolerna:mainfrom luwes:version-from-package
from-package bump option#3097luwes wants to merge 1 commit intolerna:mainfrom
luwes:version-from-package
Conversation
|
Addresses #3138 ? |
|
I don't mind the reuse of In general, I favor improving lerna's ability to publish from CI/CD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great project, we've been using Lerna w/ success over at https://github.com/muxinc/elements
Just a little thing came up with versioning and automation, below explains the issue.
Description
This change adds a new positional parameter
from-packageto keep the versions that are already in theversion's of the mono-repo packages. Definitely not set on the naming, it might be confusing with the same positional parameter in the publish command. Just wanted to create this PR and see if there's interest in this functionality? ThanksMotivation and Context
It solves an issue where one wants to set the package versions manually locally or in a PR and then let an automated CI run the actual version command generating tags (could use --amend to reuse commit), and the changelogs and release notes. This can be used with --conventional-commits because the positional takes priority when it comes to calculating the versions.
(I guess another way to tackle this issue is to have a new CLI param that disables the recommended-bump from --conventional-commits)
How Has This Been Tested?
Yes, I ran the test commands on Mac OS 12.3, Node 16.
Types of changes
Checklist: