Skip to content

feat(version): add from-package bump option#3097

Closed
luwes wants to merge 1 commit intolerna:mainfrom
luwes:version-from-package
Closed

feat(version): add from-package bump option#3097
luwes wants to merge 1 commit intolerna:mainfrom
luwes:version-from-package

Conversation

@luwes
Copy link
Copy Markdown

@luwes luwes commented Mar 30, 2022

Thanks for this great project, we've been using Lerna w/ success over at https://github.com/muxinc/elements
Just a little thing came up with versioning and automation, below explains the issue.

Description

This change adds a new positional parameter from-package to keep the versions that are already in the version's of the mono-repo packages. Definitely not set on the naming, it might be confusing with the same positional parameter in the publish command. Just wanted to create this PR and see if there's interest in this functionality? Thanks

Motivation and Context

It solves an issue where one wants to set the package versions manually locally or in a PR and then let an automated CI run the actual version command generating tags (could use --amend to reuse commit), and the changelogs and release notes. This can be used with --conventional-commits because the positional takes priority when it comes to calculating the versions.

(I guess another way to tackle this issue is to have a new CLI param that disables the recommended-bump from --conventional-commits)

How Has This Been Tested?

Yes, I ran the test commands on Mac OS 12.3, Node 16.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joebowbeer
Copy link
Copy Markdown

Addresses #3138 ?

@joebowbeer
Copy link
Copy Markdown

I don't mind the reuse of from-package

In general, I favor improving lerna's ability to publish from CI/CD

@luwes luwes closed this by deleting the head repository Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants