fix(bootstrap): Run lifecycle scripts in topological queue instead of batches#2224
Merged
evocateur merged 1 commit intolerna:masterfrom Oct 7, 2019
Merged
Conversation
evocateur
approved these changes
Oct 7, 2019
Member
evocateur
left a comment
There was a problem hiding this comment.
LGTM. We can remove the unused packages separately.
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
@lerna/bootstrapso that it usedrunTopologicallyinstead of the oldbatchPackages@lerna/batch-packagesand@lerna/run-parallel-batchesaren't used anymore by any other package of the monorepo, but I don't know which is the process needed to remove them.Motivation and Context
While updating lerna in the Babel repo, I noticed that the old cycles warnings (which should have been disappeared after #2185) were still there.
After investigating a bit, I realized that the old
partitionCyclesmethod was still used by@lerna/batch-packages.How Has This Been Tested?
Only using the tests in this repo
Types of changes
Checklist: