Skip to content

Use sync-exec for node 0.10#220

Merged
hzoo merged 1 commit intomasterfrom
sync-exec
Jun 14, 2016
Merged

Use sync-exec for node 0.10#220
hzoo merged 1 commit intomasterfrom
sync-exec

Conversation

@hzoo
Copy link
Copy Markdown
Contributor

@hzoo hzoo commented Jun 14, 2016

If we are going to support node 0.10

  • 0.10 doesn't have child_process.execSync

Fixes #157

@jamiebuilds
Copy link
Copy Markdown
Contributor

Sure, want to add 0.10 to the travis.yml?

@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Jun 14, 2016

Ok - maybe later we can do the same as babel and setup circleci to run 0.10, or move on of those to appveyor for windows

@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Jun 14, 2016

added circle ci for 0.10 as alternative - failing test is just a timeout

@jamiebuilds
Copy link
Copy Markdown
Contributor

Why circle ci?

@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Jun 14, 2016

Just doing what we did in babel (don't have to)

- 0.10 doesn't have child_process.execSync

Ref #157
@hzoo hzoo merged commit 062ae97 into master Jun 14, 2016
@hzoo hzoo deleted the sync-exec branch June 14, 2016 21:41
@jamiebuilds
Copy link
Copy Markdown
Contributor

Yeah, I don't want circle ci for no reason. I'd rather just add 0.10 to the list of travis versions.

@lock
Copy link
Copy Markdown

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants