Skip to content

fix(publish): Add --graph-type option to control packages included in topological sort#2152

Merged
evocateur merged 2 commits intolerna:masterfrom
padraig-meaney:bugfix/1437
Jul 18, 2019
Merged

fix(publish): Add --graph-type option to control packages included in topological sort#2152
evocateur merged 2 commits intolerna:masterfrom
padraig-meaney:bugfix/1437

Conversation

@padraig-meaney
Copy link
Contributor

Allow for configuration of a specific graphType, so that users can opt-in to using devDependencies when building a package graph during publish.

Closes #1437.

Description

Added a new option, graph-type, to the publish command. The default value for this option does not change any existing behaviour.

Not sure what tests I should add for this change though.

Motivation and Context

See #1437.

How Has This Been Tested?

Ran the existing test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur changed the title fix(publish): Allow specifying a graph-type fix(publish): Add --graph-type option to control packages included in topological sort Jul 18, 2019
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

padraig-meaney and others added 2 commits July 18, 2019 12:17
Allow for configuration of a specific graphType, so that users can opt-in to using devDependencies when building a package graph during publish.

Closes lerna#1437.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing order should take peerDependencies into account

2 participants