feat(bootstrap): Add --strict option to enable throwing when --hoist warns#2140
Merged
evocateur merged 2 commits intolerna:masterfrom Jul 18, 2019
jnielson94:feat/strict-hoist
Merged
feat(bootstrap): Add --strict option to enable throwing when --hoist warns#2140evocateur merged 2 commits intolerna:masterfrom jnielson94:feat/strict-hoist
--strict option to enable throwing when --hoist warns#2140evocateur merged 2 commits intolerna:masterfrom
jnielson94:feat/strict-hoist
Conversation
Contributor
Author
|
@evocateur - When you have a minute to review this, we'd appreciate it :) We have a hacky work around right now, but it would be nice to have an official option. |
--strict option to enable throwing when --hoist warns
Member
|
(Apologies for the delay, thank you for your patience) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an option that will throw an error after printing out the hoist warnings (if there were any) to allow the bootstrap process to stop if there are version conflicts.
Motivation and Context
Fixes #2139 (and #667 although that was closed long ago).
How Has This Been Tested?
I added a unit test, and tried it out in our project (after spending a decent chunk of time dealing with trying to get linking working...), seemed to work just great.
Types of changes
Checklist:
Please let me know if I did something that I shouldn't have or things to adjust :)