Skip to content

Conversation

@JamesHenry
Copy link
Member

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Nov 3, 2025

View your CI Pipeline Execution ↗ for commit bcbe3c3

Command Status Duration Result
nx run-many --t e2e --parallel=1 ✅ Succeeded 1m 21s View ↗
nx run-many -t lint --parallel=3 ✅ Succeeded 10s View ↗
nx run-many -t build ✅ Succeeded 2s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 2s View ↗
nx run integration:integration --ci --maxWorkers=2 ✅ Succeeded <1s View ↗
nx run-many -t build --parallel=3 ✅ Succeeded <1s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded <1s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-14 09:18:29 UTC

@JamesHenry JamesHenry marked this pull request as draft November 3, 2025 12:03
nx-cloud[bot]

This comment was marked as outdated.

@tay1orjones
Copy link

I'm glad to see this and would love to see it get in soon as we're running into the issues described and fixed over in

We want to use OIDC but we can't update to lerna v9 because of this blocker.

@JamesHenry
Copy link
Member Author

JamesHenry commented Nov 7, 2025

@tay1orjones sure, one of the reasons this stalled this week was because it uncovered some pretty wonky behaviour around git versions that is covered by very old tests (from many years before we took over).

Essentially Nx's dependency graph got more accurate with regards to local dependencies and lerna's old tests here are expecting something extremely loose/inaccurate.

We've discussed it internally and we're classing this as a bug fix and not a breaking change, as much as anything because there are now many better options for specifying a local dependency than a git/github reference back to the same repo. Indeed our hypothesis is that these tests and expected behaviour might well be before things like file: and workspace: were even a thing.

I am now looking into the other failures

@JamesHenry
Copy link
Member Author

Looks like the remaining failures were a Windows specific regression: nrwl/nx#33408

I will get this branch updated once an Nx patch is available with that in

@JamesHenry JamesHenry marked this pull request as ready for review November 14, 2025 09:18
@JamesHenry JamesHenry merged commit 0cca286 into main Nov 14, 2025
17 checks passed
@JamesHenry JamesHenry deleted the nx-22 branch November 14, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants