-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: expand version range to include nx v22.x #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit bcbe3c3
☁️ Nx Cloud last updated this comment at |
|
I'm glad to see this and would love to see it get in soon as we're running into the issues described and fixed over in We want to use OIDC but we can't update to lerna v9 because of this blocker. |
|
@tay1orjones sure, one of the reasons this stalled this week was because it uncovered some pretty wonky behaviour around git versions that is covered by very old tests (from many years before we took over). Essentially Nx's dependency graph got more accurate with regards to local dependencies and lerna's old tests here are expecting something extremely loose/inaccurate. We've discussed it internally and we're classing this as a bug fix and not a breaking change, as much as anything because there are now many better options for specifying a local dependency than a git/github reference back to the same repo. Indeed our hypothesis is that these tests and expected behaviour might well be before things like I am now looking into the other failures |
|
Looks like the remaining failures were a Windows specific regression: nrwl/nx#33408 I will get this branch updated once an Nx patch is available with that in |
No description provided.