Skip to content

fix(version): disable legacy peer deps behavior by default #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesHenry merged 1 commit into from
Apr 10, 2025
Merged

fix(version): disable legacy peer deps behavior by default #4175

JamesHenry merged 1 commit into from
Apr 10, 2025

Conversation

@jaysoo
Copy link
Contributor

@jaysoo jaysoo commented Apr 9, 2025

This PR fixes the lockfile bug as described here: #4167

Description

When NX_ISOLATE_PLUGIN was set to false, it uncovered an issue where Nx defaults npm_config_legacy_peer_deps environment variable to true. This means that subsequent npm install command is updating the lockfile (i.e. package-lock.json) in an unexpected manner.

Motivation and Context

Fixes #4167

How Has This Been Tested?

Manually making the changes locally and testing it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry mentioned this pull request Apr 9, 2025
Closed
10 tasks
@nx-cloud
Copy link

nx-cloud bot commented Apr 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4c2b6a8.

Command Status Duration Result
nx run-many --t e2e --parallel=1 ✅ Succeeded 11m 17s View ↗
nx run integration:integration --ci --maxWorkers=2 ✅ Succeeded 3m 22s View ↗
nx run-many -t lint --parallel=3 ✅ Succeeded 2m 7s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 1m 50s View ↗
nx run-many -t build --parallel=3 ✅ Succeeded 1m 42s View ↗
nx run-many -t build ✅ Succeeded 4s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 2s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 3m 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 17:34:01 UTC

@jaysoo jaysoo mentioned this pull request Apr 9, 2025
Closed
janthurau added a commit to ueberdosis/hocuspocus that referenced this pull request Apr 9, 2025
@janthurau
downgrade lerna to fix lerna/lerna#4175
203e83b
janthurau added a commit to ueberdosis/hocuspocus that referenced this pull request Apr 9, 2025
@janthurau
adds npm_config_legacy_peer_deps=false to lerna commands to fix lerna…
d761516 
…/lerna#4175
@JamesHenry JamesHenry merged commit 0cd3241 into lerna:main Apr 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lerna v8.2.0+ removes package-lock.json dependencies on lerna version.

2 participants

@jaysoo @JamesHenry